cranelift: Upgrade libm to 0.2.4#4670
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Aug 10, 2022
Merged
Conversation
This resolves an issue with incorrect fmaf on the x86_64-pc-windows-gnu target under some inputs. See: bytecodealliance#4517
Contributor
Author
|
It looks like this fails (expectedly) in cargo-vet. However, it is my understanding that only Bytecode Alliance members can modify this / approve new deps. I think this was mentioned in one of the cranelift meetings, but can't find the exact policy in the repository. @alexcrichton is this the case? |
bjorn3
reviewed
Aug 10, 2022
alexcrichton
approved these changes
Aug 10, 2022
Member
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks!
If you add this diff to this PR that should appease cargo vet:
diff --git a/supply-chain/audits.toml b/supply-chain/audits.toml
index 9a4b9bd23..c172585c1 100644
--- a/supply-chain/audits.toml
+++ b/supply-chain/audits.toml
@@ -19,6 +19,16 @@ criteria = "safe-to-deploy"
version = "1.0.0"
notes = "I am the author of this crate."
+[[audits.libm]]
+who = "Alex Crichton <alex@alexcrichton.com>"
+criteria = "safe-to-deploy"
+delta = "0.2.2 -> 0.2.4"
+notes = """
+This diff primarily fixes a few issues with the `fma`-related functions,
+but also contains some other minor fixes as well. Everything looks A-OK and
+as expected.
+"""
+
[[audits.regalloc2]]
who = "Jamey Sharp <jsharp@fastly.com>"
criteria = "safe-to-deploy"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves an issue with incorrect
fmafon the x86_64-pc-windows-gnu target under some inputs.This was fixed in rust-lang/libm#267
See: #4517