cranelift-fuzzgen: use a different namespace#4795
cranelift-fuzzgen: use a different namespace#4795jameysharp merged 1 commit intobytecodealliance:mainfrom
Conversation
Otherwise I get a panic with "Duplicate function with name u0:1 found!" at fuzz/fuzz_targets/cranelift-fuzzgen.rs:76:10.
github-actions
bot
added
the
cranelift
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
This is because the randomly generated input contains other functions in the u0:x namespace presumably? A little more reasoning in the comment would be helpful, for the curious reader; but moving to a different toplevel function name (u1:0 rather than u0:1) shouldn't hurt anything if consistent. So this LGTM.
Avoiding setting r+ bit because of above request and auto-merge but happy to approve with a slightly more detailed comment.
|
It's actually because the trampolines and renamed functions are in namespace 0. References to other (non-existent) functions should be fine since they get renamed. I think? |
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
Makes sense; happy to see this merge as-is then, just to get the fuzzer fix in. Thanks!
|
Thanks! And sorry for the mess this created. The hard coded function names should go away when we start generating random function names. |
|
No worries! I think the only "mess" was my flailing around in different issues trying to figure out what happened. 😆 |
3 participants
Otherwise I get a panic with "Duplicate function with name u0:1 found!"
at fuzz/fuzz_targets/cranelift-fuzzgen.rs:76:10.