Disable funcref generation for fuzz tests with inputs#4797
Merged
jameysharp merged 1 commit intobytecodealliance:mainfrom Aug 29, 2022
Merged
Disable funcref generation for fuzz tests with inputs#4797jameysharp merged 1 commit intobytecodealliance:mainfrom
jameysharp merged 1 commit intobytecodealliance:mainfrom
Conversation
This fixes bytecodealliance#4757, fixes bytecodealliance#4758, and fixes new fuzzbugs that are probably coming after we merged bytecodealliance#4667.
github-actions
bot
added
the
cranelift
8 tasks
afonso360
approved these changes
Aug 27, 2022
cfallin
approved these changes
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge until we're ready to invalidate all of our currently-open
cranelift-fuzzgenfuzz-bugs.Per @afonso360's suggestion on #4758, this makes
cranelift-fuzzgenstop generating references to functions which don't exist. It also disables generating libcalls, which weren't that big of a problem, but it's fine to just not test them until we have those bits in better shape.This fixes #4757, fixes #4758, and fixes new fuzzbugs that are probably coming after we merged #4667.