Add a missing compilation feature for windows-sys#5135
Closed
alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Closed
Add a missing compilation feature for windows-sys#5135alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
windows-sys#5135alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
This fixes a compilation error on Windows when just the `wasmtime` crate is compiled. If the `async` feature and `wasi-common` are omitted then otherwise this feature was accidentally not included. This was not caught on our CI only performs these minimal build checks on Linux, not on Windows as well. Closes bytecodealliance#5133
Member
Author
|
Duplicate of #5134 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a compilation error on Windows when just the
wasmtimecrate is compiled. If theasyncfeature andwasi-commonare omitted then otherwise this feature was accidentally not included. This was not caught on our CI only performs these minimal build checks on Linux, not on Windows as well.Closes #5133