Update the documentation for Caller::get_export.#5556
Merged
abrown merged 1 commit intobytecodealliance:mainfrom Jan 11, 2023
Merged
Update the documentation for Caller::get_export.#5556abrown merged 1 commit intobytecodealliance:mainfrom
Caller::get_export.#5556abrown merged 1 commit intobytecodealliance:mainfrom
Conversation
Update the documentation for `Caller::get_export` to clarify that it's not expected to be removed in the future. Components do offer an alternative to `Caller::get_export`, so add a brief note mentioning that. Also, as of bytecodealliance#4431 `get_export` now works for all exports, not just memories and functions.
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
abrown
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the documentation for
Caller::get_exportto clarify that it's not expected to be removed in the future. Components do offer an alternative toCaller::get_export, so add a brief note mentioning that.Also, as of #4431
get_exportnow works for all exports, not just memories and functions.