Update base64 dependency to 0.21.0#5702
Conversation
brendandburns
commented
Feb 3, 2023
- This is related to [WIP] Add a wasi-http support as a module #5678 there's a dependency mis-match that between some libraries I need for HTTP and the (old) base64 crate in wasmtime.
- Revs the base64 dependency to 0.21.0, small API change.
- This PR contains test cases, if meaningful. Not necessary, covered by existing tests.
|
Agree we should update this dep, but I need to learn how to use |
|
Please rebase on main after #5707 merges, and remove the last commit modifying the vet toml. Thanks! |
|
@pchickey rebased, thanks for taking care of the vet part. |
|
So, I dropped my cargo vet related commit, perhaps I wasn't supposed to do that? Anyway, I'm still seeing this cargo vet error: Let me know the right way to fix this. Thanks! |
|
Nope, thats me making a mistake on the vetting. I'll fix it |
|
#5710 will fix the vet problem, someone will review it monday. Sorry! |
|
I checked a rebase on main locally and this should be fixed now |
|
Thanks @pchickey for the fixes and @peterhuene for the quick merge! |