Fix feature-gating of test-programs#612
Merged
kubkon merged 2 commits intobytecodealliance:masterfrom Nov 21, 2019
Merged
Conversation
This commit fixes bugs in enabling feature-gating of `test-programs` which was introduced in bytecodealliance#600. It turns out, bytecodealliance#600 accidentally disabled `test-programs` from ever running, and this commit fixes that.
Member
Author
|
@joshtriplett I'm gonna make an executive decision here, and will merge it as-is as otherwise any new PR to this repo will not test our WASI implementation. That's entirely my fault for accidentally disabling the tests in #600, apologies! Anyhow, if you feel that we should revert all changes introduced in #600 and this PR, feel free to submit an issue and/or revert PRs 👍 |
Member
|
@kubkon seems reasonable to me! |
arkpar
pushed a commit
to paritytech/wasmtime
that referenced
this pull request
Mar 4, 2020
* Impoved support for wasm global imports * Refactored parse_import_section improving readability * Improved support for wasm table imports * Improved support for wasm memory imports * Improved formatting * Added DefinedGlobalIndex, DefinedMemoryIndex, DefinedTableIndex structs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes bugs in enabling feature-gating of
test-programswhich was introduced in #600. It turns out, #600 accidentally
disabled
test-programsfrom ever running, and this commit fixesthat.