Wasi: preview2 poll-oneoff returns list<bool>#6498
Merged
Conversation
pchickey
requested review from
fitzgen and
sunfishcode
and removed request for
a team and
fitzgen
Contributor
Author
|
This will conflict with #6486. We can upstream the wit fix to the standards repo, rebase on main after 6486 lands, and then merge this, since this is a very minor change. |
fitzgen
approved these changes
Jun 1, 2023
pchickey
pushed a commit
to WebAssembly/wasi-poll
that referenced
this pull request
Jun 10, 2023
In the early days of the preview2 prototype, there was some trouble with wit-bindgen that made it impossible to return a list<bool> from the poll-oneoff function. This bug has since been resolved: bytecodealliance/wasmtime#6498
pchickey
pushed a commit
to WebAssembly/wasi-poll
that referenced
this pull request
Jun 10, 2023
In the early days of the preview2 prototype, there was some trouble with wit-bindgen that made it impossible to return a list<bool> from the poll-oneoff function. This bug has since been resolved: bytecodealliance/wasmtime#6498
sunfishcode
pushed a commit
to WebAssembly/wasi-poll
that referenced
this pull request
Jun 11, 2023
In the early days of the preview2 prototype, there was some trouble with wit-bindgen that made it impossible to return a list<bool> from the poll-oneoff function. This bug has since been resolved: bytecodealliance/wasmtime#6498
Member
|
I don't believe this was supposed to be closed by that PR, so reopening |
sunfishcode
reviewed
Jun 12, 2023
| // The generated definition of command will pull in std, so we are defining it | ||
| // manually below instead | ||
| skip: ["run", "get-directories", "get-environment"], | ||
| skip: ["run", "get-environment", "poll-oneoff"], |
Member
There was a problem hiding this comment.
Could you add a comment about why poll-oneoff is skip here, and has manual bindings below instead?
added 5 commits
June 27, 2023 10:21
pchickey
force-pushed
the
pch/poll_oneoff_return_list_bool
branch
from
258aade to
d76f4f4
Compare
saulecabrera
pushed a commit
to saulecabrera/wasmtime
that referenced
this pull request
Jun 28, 2023
* poll.wit: we can returl a list<bool> now * adapter: fixes for poll-oneoff returning list<bool> * wasi preview2: fixes for poll-oneoff returning list<bool> * adapter: manually import poll-oneoff to avoid pulling in std to allocate return vec * comment describing the skip functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the early days of the preview2 prototype, there was some trouble with wit-bindgen that made it impossible to return a
list<bool>from thepoll-oneofffunction.This bug has since been resolved. The poll-oneoff definition in wit has been modified to return
list<bool>and minor tweaks have been made at use sites to use the boolean.