Resolve trappable error types with fully qualified package paths#6795
Merged
pchickey merged 2 commits intobytecodealliance:mainfrom Aug 3, 2023
Merged
Resolve trappable error types with fully qualified package paths#6795pchickey merged 2 commits intobytecodealliance:mainfrom
pchickey merged 2 commits intobytecodealliance:mainfrom
Conversation
elliottt
requested review from
jameysharp and
pchickey
and removed request for
a team
elliottt
force-pushed
the
trevor/trappable-types
branch
4 times, most recently
from
f39e0bb to
8f4dfb1
Compare
pchickey
approved these changes
Aug 3, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
elliottt
force-pushed
the
trevor/trappable-types
branch
from
8f4dfb1 to
5f242d2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
This got kicked from the merge queue for what appears to be s390x taking too long, which tends to happen with some frequency during the business day. I put it back in |
geekbeast
pushed a commit
to geekbeast/wasmtime
that referenced
this pull request
Aug 6, 2023
… feature/preview2 * 'feature/preview2' of github.com:geekbeast/wasmtime: Change preview2 builder methods to use `&mut self` (bytecodealliance#6770) Add a bindgen test that exercises using error types from a different interface (bytecodealliance#6802) Resolve trappable error types with fully qualified package paths (bytecodealliance#6795) Update the dev-dependency for wit-bindgen to 0.9.0 (bytecodealliance#6800) Fix incorrect sample code in documentation (bytecodealliance#6796) (bytecodealliance#6797) Update preview1 to trap on misaligned pointers (bytecodealliance#6776) Fix posix-signals-on-macos on aarch64-apple-darwin (bytecodealliance#6793) consistient WASI preview1 rights reporting (bytecodealliance#6784) Wasmtime: Introduce `{Module,Component}::resources_required` (bytecodealliance#6789)
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Aug 18, 2023
…ecodealliance#6795) * Switch trappable_error_type to take a fully-qualified type path * Print trappable error types from other interfaces with their module path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to parsing the
trappable_error_typefield of thebindgen!macro to expect the first part of the path to be a wit package path. Instead oftypes::error: MyError, you would now pass"namespace:package/types"::error: MyError. This allows us to resolve the referenced type in wit without ambiguity, when it's used across interfaces.