Skip to content

[s390x] Improve handling of negative i32 constants #6952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfallin merged 1 commit into from
Sep 2, 2023
Merged

[s390x] Improve handling of negative i32 constants #6952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cranelift/codegen/src/isa/s390x/inst.isle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2989,7 +2989,7 @@
dst))

;; 32-bit result type, value fits in i16
(rule 6 (imm (gpr32_ty ty) (i16_from_u64 n))
(rule 6 (imm (gpr32_ty ty) (u32_pair _ (i16_from_u32 n)))
(let ((dst WritableReg (temp_writable_reg ty))
(_ Unit (emit (MInst.Mov32SImm16 dst n))))
dst))
Expand Down
4 changes: 2 additions & 2 deletions cranelift/filetests/filetests/isa/s390x/constants.clif
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,11 @@ block0:

; VCode:
; block0:
; iilf %r2, 4294967295
; lhi %r2, -1
; br %r14
;
; Disassembled:
; block0: ; offset 0x0
; iilf %r2, 0xffffffff
; lhi %r2, -1
; br %r14