cranelift: Fix fuzzgen iconst encoding#6967
Merged
Conversation
ghost
self-requested a review
as a 
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Sep 6, 2023
Resolves bytecodealliance#6965 Linked to bytecodealliance#3059 bytecodealliance#6850 bytecodealliance#6958 Co-authored-by: Afonso Bordado <afonso360@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this work has been discussed elsewhere:
#6965
Explain why this change is needed:
Since #6850, the immediate of
iconst.i32 -2is encoded inUnaryImm::immas0xffff_fffe, and not-2, despite being stored in a signed 64-bit integer. The fuzzing generator foriconsthas not been modified accordingly and is still encoding the previous example as-2. This PR fixes that.