Skip to content

chore: backport 6878 to release-13.0.0#6974

Merged
pchickey merged 1 commit intobytecodealliance:release-13.0.0from
eduardomourar:feat/backport-pr-6878
Sep 11, 2023
Merged

chore: backport 6878 to release-13.0.0#6974
pchickey merged 1 commit intobytecodealliance:release-13.0.0from
eduardomourar:feat/backport-pr-6878

Conversation

@eduardomourar
Copy link
Contributor

@eduardomourar eduardomourar commented Sep 6, 2023

Backporting #6878 to release v13.0.0 branch.

…iance#6878)

* feat(wasmtime-cli): add async support flag

Within the wasmtime CLI, the current default behavior
is to only inject the synchronous functions to linkers.
This will add a flag called `--async` that will inject
the asynchronous one instead.

* chore: refactor wasi http crate

* feat(wasmtime-wasi): make in_tokio function public

* feat(wasi-http): define default feature called sync

* Revert "feat(wasmtime-cli): add async support flag"

This reverts commit b743ff2.

* chore: improve flaky tests for wasi http

* feat(wasi-http): expose sync api for components

* chore: add tests for sync api of wasi http components

* feat(wasmtime-cli): restore support for wasi http module

* chore: revert change to outbound http request invalid test

* chore: have extra tracing to help debugging

* feat(wasi-http): allow modules with sync functions in linker

* fix(wasi-http): missing response body in sync api

* feat: include blocking for io streams

* chore: add tests for wasi http module in cli

* chore: disable preview2 flag in wasi http test

* chore: use preview2 flag in wasi http test

* fix(wasi-http): missing stream output in sync api

* chore: fix tests for wasi http

* chore: add tracing for poll oneoff call

* chore: send exit signal on wasi http test

* chore: swap println to tracing debug

* chore: set http server timeout to 50 secs by default

* chore: add test posting large file

* chore: revert formatting in cargo toml

* chore: fix wasi-http feature and skip failing tests

prtest:full

---------

Co-authored-by: Eduardo Rodrigues <eduardomourar@users.noreply.github.com>
@eduardomourar eduardomourar requested review from a team as code owners September 6, 2023 23:55
@eduardomourar eduardomourar requested review from pchickey and removed request for a team September 6, 2023 23:55
@eduardomourar eduardomourar changed the title feat(wasmtime-cli): restore support for wasi http module (#6878) chore: backport 6878 to release-13.0.0 Sep 7, 2023
@eduardomourar
Copy link
Contributor Author

@alexcrichton, I just cherry picked the commit and resolved a few conflicts. I hope this is enough.

@github-actions github-actions bot added wasi Issues pertaining to WASI wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:c-api Issues pertaining to the C API. labels Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Subscribe to Label Action

cc @peterhuene

Details This issue or pull request has been labeled: "wasi", "wasmtime:api", "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api, wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton
Copy link
Member

This looks reasonable to me, thanks! I'll leave the final sign-off to @pchickey though as he's more familiar with this than I.

@pchickey pchickey merged commit 2ecbf48 into bytecodealliance:release-13.0.0 Sep 11, 2023
@eduardomourar eduardomourar deleted the feat/backport-pr-6878 branch September 11, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasi Issues pertaining to WASI wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:c-api Issues pertaining to the C API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants