cranelift: Add some libcalls to test interpret#7320
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Oct 21, 2023
Merged
cranelift: Add some libcalls to test interpret#7320alexcrichton merged 1 commit intobytecodealliance:mainfrom
test interpret#7320alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
github-actions
bot
added
the
cranelift
alexcrichton
approved these changes
Oct 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This is a follow up to one of @alexcrichton 's comments in #7203, where he found some fuzzing issues with RISC-V. I'm still investigating those, but this solves one of them.
Fuzzgen can currently generate a number of libcalls, these also need to be given a handler when building the interpreter. We currently have that in the fuzzgen interpreter, but don't have an equivalent in
test interpret, so when copying a failing clif case from fuzzgen it's possible to get a second error if the testcase references some libcall.I've been currently just stripping out libcalls from failing clif cases, but probably should have addressed this a while ago.
This adds the same libcalls that we have in the fuzzer, it might be worth having a default interpreter implementation in
cranelift-interpreterthat adds these, not entirely sure.