[release-13.0] Backport removal of posix-signals-on-macos#7361
Merged
alexcrichton merged 2 commits intobytecodealliance:release-13.0.0from Oct 25, 2023
Merged
[release-13.0] Backport removal of posix-signals-on-macos#7361alexcrichton merged 2 commits intobytecodealliance:release-13.0.0from
posix-signals-on-macos#7361alexcrichton merged 2 commits intobytecodealliance:release-13.0.0from
Conversation
…ce#7360) This follows up bytecodealliance#6807 and removes the last remaining reference to the removed `posix-signals-on-macos` feature flag. Note that `lib.rs` now imports `mod unix` on MacOS. This change is similar to the change in `traphandlers.rs` in bytecodealliance#6807. It is needed for hosts that use signals instead of Mach ports on MacOs.
The task was disabled due to a failing checksum. Since then, the `install-openvino-action` has improved and now _almost_ has cross-platform support. This change just restores the status quo in expectation that bytecodealliance#6895 will significantly improve the testing story. prtest:full
alexcrichton
approved these changes
Oct 25, 2023
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
I pushed up a cherry-pick which I think will fix the CI failure from prior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the leftover usage of
posix-signals-on-macos(#7360)This follows up #6807 and removes the last remaining reference to the removed
posix-signals-on-macosfeature flag.Note that
lib.rsnow importsmod unixon MacOS. This change is similar to the change intraphandlers.rsin #6807. It is needed for hosts that use signals instead of Mach ports on MacOs.