Publish Python packages on pypi on every git tag#761
Publish Python packages on pypi on every git tag#761alexcrichton merged 3 commits intobytecodealliance:masterfrom
Conversation
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Looks great to me, thanks!
@yurydelendik I think you originally published these packages? Would you be willing to configure the token?
.github/workflows/main.yml
Outdated
| publish: | ||
| name: Publish | ||
| needs: [doc_book, doc_api, wheels, build] | ||
| needs: [doc_book, doc_api, wheels, build, wheels] |
There was a problem hiding this comment.
I think wheels is already listed here?
.github/workflows/main.yml
Outdated
| find dist/ -name '*.whl' -type f -exec cp '{}' tmp/whl -v \; | ||
|
|
||
| - name: Publish Python wheels on Pypi | ||
| uses: pypa/gh-action-pypi-publish@master |
There was a problem hiding this comment.
Is there perhaps a tag or a revision we could use instead of relying on master?
(that way if this changes upstream we don't break and we have time to update ourselves)
There was a problem hiding this comment.
Sure, version 1.0.0a0 is the latest (and only) version. I'll change it.
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Looks good to me! Let's get the private token set up before merging though, which I think needs coordination with @yurydelendik
|
Ok should be configured and good to go! |
|
Great! |
* Publish Python wheels on pypi on every git tag * Remove config required for testing * Pin workflow version & remove duplicate dependency
2 participants
This commit adds support for publishing the wasmtime Python packages to the Python Package Index (pypi) on every release.
This PR consists of 2 commits. Most work is done in 1f51bed.
In order to test my changes I had to introduce things which I undid it the last commit 970313b
You can see the logs of the CI job in here.
Note The CI job requires an access token in order to upload the packages to pypi. The token can be obtained in the settings menu of the package. See the screenshot:
This token must be added to Github as a secret by the name pypi_password as is shown in the screenshot.
Fixes: #312