Fix generating interface names which are Rust keywords#7790
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Feb 12, 2024
Merged
Fix generating interface names which are Rust keywords#7790alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
Archisman-Mridha
requested review from
pchickey
and removed request for
a team
Archisman-Mridha
changed the title
Member
|
Thanks! With the test failure on CI I think there may be a few more cases that need to be handled? |
Signed-off-by: Archisman Mridha <archismanmridha12345@gmail.com>
Archisman-Mridha
force-pushed
the
fix/7784
branch
from
e7654bb to
cacf0a1
Compare
Contributor
Author
|
Hey, sorry for stretching this. I had to deal with my exams :). My earlier commit wasn't the actual solution to the problem. I have pushed another commit containing the actual fix. Please approve the CI when you get time. |
alexcrichton
approved these changes
Feb 12, 2024
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
No worries, and thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7784