Closed
Conversation
mitiation -> mitigation
Member
|
Thanks for the PR! #81 has now fixed this though, which by random chance I happened to see first. |
mooori
pushed a commit
to mooori/wasmtime
that referenced
this pull request
Dec 20, 2023
zkasm: i32 overflows
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
Jan 26, 2024
Merge with upstream
dicej
added a commit
to dicej/wasmtime
that referenced
this pull request
Mar 21, 2025
This updates the CM async support to match recent (and not-so-recent) spec changes: - Use waitable-sets to track and deliver events for waitables - Expect packed (`CallbackCode`, waitable-set) tuples from exports and callbacks - Remove `Event.DONE`, which no longer exists - Update the semantics of `subtask.drop` given that it can be called before the subtask has finished - Allow the read and write ends of a stream or future to be added to separate waitable-sets The last item required a fair amount of refactoring to give each end of a stream or future its own handle. The `subtask.drop`/`Event.DONE` changes mean that the parent of a subtask may finish before the subtask does, in which case we must "reparent" the subtask to point to its grandparent (or host, if applicable). This is akin to an "async tail call" such that long-lived subtasks "bubble up" the call stack as its caller (and it's caller's caller, etc.) finish. Note that I've temporarily pointed the wit-bindgen and wasm-tools deps to my fork; I'll open PRs to get those changes upstreamed soon. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Oct 8, 2025
…-main-return-non-zero wizer.h: handle the case when wasi command main function returns non-zero code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello and thanks for creating this project, it looks very interesting!
I noticed a typo in the Readme, which is fixed in this PR.
mitiations -> mitigations