Merged
Conversation
This fixes the build on the latest nightly Rust. I was able to vet `ahash` itself but `zerocopy` is such a large and full-of-unsafe dependency I've added an exemption for it. The documentation of it seems to indicate it's a pretty well thought out crate with lots of care behind it, so at least at a first glance it did not seem overly worrisome.
abrown
approved these changes
Feb 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the build on the latest nightly Rust. I was able to vet
ahashitself butzerocopyis such a large and full-of-unsafe dependency I've added an exemption for it. The documentation of it seems to indicate it's a pretty well thought out crate with lots of care behind it, so at least at a first glance it did not seem overly worrisome.Closes #7896