x64: Add fcvt_from_uint lowering for i64x2#7919
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Feb 12, 2024
Merged
x64: Add fcvt_from_uint lowering for i64x2#7919fitzgen merged 1 commit intobytecodealliance:mainfrom
fcvt_from_uint lowering for i64x2#7919fitzgen merged 1 commit intobytecodealliance:mainfrom
Conversation
This commit adds a general purpose lowering for the `fcvt_from_uint` instruction in addition to the previously specialized lowering for what the wasm frontend produces. This is unlikely to get triggered much from the wasm frontend except when intermediate optimizations change the shape of code. The goal of this commit is to address issues such as those identified in bytecodealliance#7915 and historically by ensuring that there's a lowering for the instruction for all input types instead of trying to massage the input into the right form. This instruction lowering was crafted by studying LLVM's output and I've put commentary to the best of my ability as to what's going on.
github-actions
bot
added
cranelift
fitzgen
approved these changes
Feb 12, 2024
Comment on lines
+3434
to
+3435
| ;; Apply some math and this should produce the same result as the native | ||
| ;; conversion. |
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Mar 12, 2024
This instruction was previously unimplemented in Cranelift as pointed out in bytecodealliance#8084. While a fallback for `fcvt_from_uint` was implemented in bytecodealliance#7919 I forgot to do the same for the signed version. This commit adds a fallback that decomposes the input into two scalars and converts each individually, then reassembling the result.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Mar 12, 2024
This instruction was previously unimplemented in Cranelift as pointed out in bytecodealliance#8084. While a fallback for `fcvt_from_uint` was implemented in bytecodealliance#7919 I forgot to do the same for the signed version. This commit adds a fallback that decomposes the input into two scalars and converts each individually, then reassembling the result.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
This instruction was previously unimplemented in Cranelift as pointed out in #8084. While a fallback for `fcvt_from_uint` was implemented in #7919 I forgot to do the same for the signed version. This commit adds a fallback that decomposes the input into two scalars and converts each individually, then reassembling the result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a general purpose lowering for the
fcvt_from_uintinstruction in addition to the previously specialized lowering for what the wasm frontend produces. This is unlikely to get triggered much from the wasm frontend except when intermediate optimizations change the shape of code. The goal of this commit is to address issues such as those identified in #7915 and historically by ensuring that there's a lowering for the instruction for all input types instead of trying to massage the input into the right form.This instruction lowering was crafted by studying LLVM's output and I've put commentary to the best of my ability as to what's going on.