Add a CodeBuilder type to the wasmtime crate#8181
Add a CodeBuilder type to the wasmtime crate#8181alexcrichton merged 5 commits intobytecodealliance:mainfrom
CodeBuilder type to the wasmtime crate#8181Conversation
This commit is extracted from bytecodealliance#8055 and adds a new `ModuleBuilder` type which is intended to be able to further configure compilation beyond what the constructors of `Module` already provide. For example in bytecodealliance#8055 knobs will be added to process `*.dwp` files for more debuginfo processing. Co-authored-by: yowl00 <scott.waye@hubse.com>
|
I'll note that while I've called this |
github-actions
bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
LGTM!
As far as naming goes, the only alternatives I can think of are
ModuleOrComponentBuilderCodeBuilder
Or maybe splitting this type in two in the public API (and sharing an underlying impl) so that we have both a ModuleBuilder and a ComponentBuilder.
| /// WebAssembly module. Less advanced configuration can use constructors such | ||
| /// as: |
There was a problem hiding this comment.
| /// WebAssembly module. Less advanced configuration can use constructors such | |
| /// as: | |
| /// WebAssembly module. Most configuration can use simple constructors such | |
| /// as: |
There was a problem hiding this comment.
(Don't want to create a weird "advanced" vs not thing where people who consider themselves Serious Wasmtime Users will want to use this without actually having a good reason. Might be overthinking things here.)
|
It feels kind of nice being able to configure components/modules in one builder since it's all wasm anyway so I think I'll stick with one for now vs copying APIs, but I'll rename to |
alexcrichton
changed the title
ModuleBuilder type to the wasmtime crateCodeBuilder type to the wasmtime crate
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This commit fixes a mistake in bytecodealliance#8181 which meant that the caching for components was no longer working. The mistake is fixed in this commit as well as a new test being added too.
This commit fixes a mistake in #8181 which meant that the caching for components was no longer working. The mistake is fixed in this commit as well as a new test being added too.
2 participants
This commit is extracted from #8055 and adds a new
CodeBuildertype which is intended to be able to further configure compilation beyond what the constructors ofModulealready provide. For example in #8055 knobs will be added to process*.dwpfiles for more debuginfo processing.