egraph: Resolve all aliases at once#8240
Merged
jameysharp merged 2 commits intobytecodealliance:mainfrom Mar 28, 2024
Merged
Conversation
github-actions
bot
added
the
cranelift
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This way we can use the linear-time alias rewriting pass, and then avoid having to think about value aliases ever again.
When resolving aliases in values_labels, this discards debug info on values which are replaced by aliases. However, that is equivalent to the existing behavior in `Lower::get_value_labels`, which resolves value aliases first and only then looks for attached debug info.
jameysharp
force-pushed
the
resolve-egraph-aliases
branch
from
82ab57d to
70b0827
Compare
Contributor
Author
|
@cfallin, could you have a look at my additional changes in 70b0827 and make sure they make sense? CI informed me that values deleted due to this alias-rewrite pass were still referenced. While auditing everything in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we can use the linear-time alias rewriting pass, and then avoid having to think about value aliases ever again.