Use WASI builder directly in C API#8572
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom May 7, 2024
Merged
Conversation
This commit updates the C API to use the `WasiCtxBuilder` directly within `wasi_config_t` instead of buffering up the options separately. This keeps the behavior of the Rust-based API more similar to the C API and should also help resolve bytecodealliance#8552 due to errors being returned more eagerly in the builder-based API. This additionally makes some minor modifications to the C APIs here as appropriate. Close bytecodealliance#8552
Contributor
|
@alexcrichton Since I've been looking at this PR: do you think you could expose memory stdio in wasmtime-py? |
Member
Author
|
Sure yeah! Should be simple enough, the functions just didn't exist when I first wrote wasmtime-py |
pchickey
approved these changes
May 7, 2024
Contributor
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
Nice simplification. One minor bug
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
May 7, 2024
* Use WASI builder directly in C API This commit updates the C API to use the `WasiCtxBuilder` directly within `wasi_config_t` instead of buffering up the options separately. This keeps the behavior of the Rust-based API more similar to the C API and should also help resolve bytecodealliance#8552 due to errors being returned more eagerly in the builder-based API. This additionally makes some minor modifications to the C APIs here as appropriate. Close bytecodealliance#8552 * Review comments
alexcrichton
added a commit
that referenced
this pull request
May 7, 2024
* Use WASI builder directly in C API This commit updates the C API to use the `WasiCtxBuilder` directly within `wasi_config_t` instead of buffering up the options separately. This keeps the behavior of the Rust-based API more similar to the C API and should also help resolve #8552 due to errors being returned more eagerly in the builder-based API. This additionally makes some minor modifications to the C APIs here as appropriate. Close #8552 * Review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the C API to use the
WasiCtxBuilderdirectly withinwasi_config_tinstead of buffering up the options separately. This keeps the behavior of the Rust-based API more similar to the C API and should also help resolve #8552 due to errors being returned more eagerly in the builder-based API.This additionally makes some minor modifications to the C APIs here as appropriate.
Close #8552