[21.0.0] cranelift: Always consider sret arguments used #8665
Merged
alexcrichton merged 1 commit intobytecodealliance:release-21.0.0from May 20, 2024
Merged
[21.0.0] cranelift: Always consider sret arguments used #8665alexcrichton merged 1 commit intobytecodealliance:release-21.0.0from
alexcrichton merged 1 commit intobytecodealliance:release-21.0.0from
Conversation
* cranelift: Always consider sret arguments used In bytecodealliance#8438 we stopped emitting register bindings for unused arguments, based on the use-counts from `compute_use_states`. However, that doesn't count the use of the struct-return argument that's automatically added after lowering when the `rets` instruction is generated in the epilogue. As a result, using a struct-return argument caused register allocation to panic due to the VReg not being defined anywhere. This commit adds a use to the struct-return argument so that it's always available in the epilogue. Fixes bytecodealliance#8659 * Review comments
cfallin
approved these changes
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #8664