Remove ArgumentPurpose::StackLimit#8700
Merged
elliottt merged 1 commit intobytecodealliance:mainfrom May 28, 2024
Merged
Conversation
elliottt
force-pushed
the
trevor/remove-stacklimit-arg
branch
from
abf4e14 to
c211224
Compare
Member
|
This was originally added for Wasmtime but since then Wasmtime has moved on, so sounds reasonable to me to remove 👍 |
fitzgen
approved these changes
May 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The special
stack_limitargument annotation is currently unused, so let's remove it. I have grepped through the cg clif source and didn't find anything that obviously relied on this annotation.