Add some support for imported memories to generated DWARF#8740
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Jun 5, 2024
Merged
Add some support for imported memories to generated DWARF#8740fitzgen merged 1 commit intobytecodealliance:mainfrom
fitzgen merged 1 commit intobytecodealliance:mainfrom
Conversation
This is more-or-less a prerequisite for bytecodealliance#8652 and extends the generated dwarf with expressions to not only dereference owned memories but additionally imported memories which involve some extra address calculations to be emitted in the dwarf.
fitzgen
approved these changes
Jun 5, 2024
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jun 5, 2024
This commit resolves an assert in the dwarf generating of core wasm modules when the module has a defined linear memory which is flagged `shared`. This is represented slightly differently in the `VMContext` than owned memories that aren't `shared`, and looks more like an imported memory. With support in bytecodealliance#8740 it's now much easier to support this. Closes bytecodealliance#8652
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
This commit resolves an assert in the dwarf generating of core wasm modules when the module has a defined linear memory which is flagged `shared`. This is represented slightly differently in the `VMContext` than owned memories that aren't `shared`, and looks more like an imported memory. With support in #8740 it's now much easier to support this. Closes #8652
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more-or-less a prerequisite for #8652 and extends the generated dwarf with expressions to not only dereference owned memories but additionally imported memories which involve some extra address calculations to be emitted in the dwarf.