Rename the wasm32-wasi target to wasm32-wasip1#8867
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Jul 25, 2024
Merged
Rename the wasm32-wasi target to wasm32-wasip1#8867alexcrichton merged 1 commit intobytecodealliance:mainfrom
wasm32-wasi target to wasm32-wasip1#8867alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
Member
Author
|
Ok a full CI run confirms a fear I had which is that our current MSRV of 1.77.0 doesn't support |
github-actions
bot
added
wasi
This rename is happening in upstream Rust and should be in enough places now. prtest:full
alexcrichton
force-pushed
the
rename-wasi-target
branch
from
cc38e4d to
ef4693c
Compare
Member
Author
|
Ok with our MSRV now bumped I think this should be ready to land |
abrown
approved these changes
Jul 25, 2024
Member
|
This made me think maybe we want to update this naming in wasi-sdk: WebAssembly/wasi-sdk#459? |
pchickey
approved these changes
Jul 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rename is happening in upstream Rust and should be in enough places now.
prtest:full