winch: Save state before emitting br_if#8886
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Jun 28, 2024
Merged
Conversation
Fixes: bytecodealliance#8848 Similar to all the control instructions, any state must be explicitly saved before emitting the code for `br_if`. This commit ensures that live locals and registers are explicilty saved before emitting the code for `br_if`. Prior to this commit, live locals and registers were not saved every time causing incorrect behavior in cases where the calculation of the conditional argument didn't trigger a spill. This change introduces the explicit spill after calculating the branch condition argument to minimize memory traffic in case the conditional is already in a register.
saulecabrera
requested review from
abrown and
fitzgen
and removed request for
a team
saulecabrera
changed the title
br_ifbr_if
fitzgen
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8848
Similar to all the control instructions, any state must be explicitly saved before emitting the code for
br_if.This commit ensures that live locals and registers are explicilty saved before emitting the code for
br_if. Prior to this commit, live locals and registers were not saved every time causing incorrect behavior in cases where the calculation of the conditional argument didn't trigger a spill.This change introduces the explicit spill after calculating the branch condition argument to minimize memory traffic in case the conditional is already in a register.