Skip to content

wasi-filesystem: Implement HostInputStream & HostOutputStream #9129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 14 commits into from
Aug 15, 2024
Merged

wasi-filesystem: Implement HostInputStream & HostOutputStream #9129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ea91c59
Add the ability to generate async drop methods for resources.
badeend Aug 8, 2024
d341c9a
Make `input-stream::drop` & `output-stream::drop` async
badeend Aug 10, 2024
7fbe1fe
Prevent the guest from (inadvertently) spawning an unlimited amount o…
badeend Aug 10, 2024
d1b891f
Properly clean up background tasks for even more types of I/O streams.
badeend Aug 10, 2024
b5f4f07
Let HostInput/OutputStream provide specialized blocking_* implementat…
badeend Aug 10, 2024
22f4836
Rename filesystem's `spawn_blocking` -> `run_blocking`
badeend Aug 10, 2024
402b78a
Implement specialized `blocking_write_and_flush` for FileOutputStream.
badeend Aug 10, 2024
3fb0aa9
Implement `HostInputStream` for `FileInputStream`.
badeend Aug 11, 2024
6da19c8
In Preview1 adapter: ignore BlockingMode and always perform blocking …
badeend Aug 11, 2024
33d38f9
Remove special case for FileInputStream and change InputStream enum t…
badeend Aug 11, 2024
9516306
Remove `[method]output-stream.forward` from bindgen config. It does n…
badeend Aug 11, 2024
73ed4bd
Refactor `blocking_splice` to take advantage of specialized `blocking…
badeend Aug 14, 2024
4b320c6
Merge branch 'main' of https://github.com/bytecodealliance/wasmtime i…
badeend Aug 14, 2024
7e2b7e9
Defer to regular `read` from within `blocking_read` to reduce duplica…
badeend Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/wasi-http/src/types_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ where
let body = self.table().get_mut(&id)?;

if let Some(stream) = body.take_stream() {
let stream = InputStream::Host(Box::new(stream));
let stream: InputStream = Box::new(stream);
let stream = self.table().push_child(stream, &id)?;
return Ok(Ok(stream));
}
Expand Down
6 changes: 2 additions & 4 deletions crates/wasi/src/bindings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,17 +367,15 @@ mod async_io {
"[method]descriptor.unlink-file-at",
"[method]descriptor.unlock",
"[method]descriptor.write",
"[method]input-stream.read",
"[method]input-stream.blocking-read",
"[method]input-stream.blocking-skip",
"[method]input-stream.skip",
"[method]output-stream.forward",
"[method]output-stream.splice",
"[drop]input-stream",
"[method]output-stream.blocking-splice",
"[method]output-stream.blocking-flush",
"[method]output-stream.blocking-write",
"[method]output-stream.blocking-write-and-flush",
"[method]output-stream.blocking-write-zeroes-and-flush",
"[drop]output-stream",
"[method]directory-entry-stream.read-directory-entry",
"poll",
"[method]pollable.block",
Expand Down
Loading