[wasi-http] Return none from future-trailers.get when trailers absent#9208
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Sep 6, 2024
Merged
[wasi-http] Return none from future-trailers.get when trailers absent#9208alexcrichton merged 2 commits intobytecodealliance:mainfrom
none from future-trailers.get when trailers absent#9208alexcrichton merged 2 commits intobytecodealliance:mainfrom
Conversation
…sent Previously, we would return `error-code::connection-terminated` in this case, whereas the `wasi-http` spec says we should simply return `none` (i.e. it's not an error if there are no trailers present). This also adds code to `api_proxy_streaming.rs` to check for trailers after reading the body content. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
approved these changes
Sep 6, 2024
Member
|
Thanks! |
dicej
added a commit
to dicej/runtimelab
that referenced
this pull request
Nov 14, 2024
v26.0.1 includes bytecodealliance/wasmtime#9208, which came up while implementing dotnet/runtime#109840 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
jkotas
pushed a commit
to dotnet/runtimelab
that referenced
this pull request
Nov 14, 2024
v26.0.1 includes bytecodealliance/wasmtime#9208, which came up while implementing dotnet/runtime#109840 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we would return
error-code::connection-terminatedin this case, whereas thewasi-httpspec says we should simply returnnone(i.e. it's not an error if there are no trailers present).This also adds code to
api_proxy_streaming.rsto check for trailers after reading the body content.