c#: Add cli option to generate Result types#1115
Merged
dicej merged 3 commits intobytecodealliance:mainfrom Jan 16, 2025
Merged
c#: Add cli option to generate Result types#1115dicej merged 3 commits intobytecodealliance:mainfrom
dicej merged 3 commits intobytecodealliance:mainfrom
Conversation
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
jsturtevant
force-pushed
the
use-results
branch
from
9e0e77c to
d77a265
Compare
jsturtevant
commented
Jan 8, 2025
|
|
||
| /// Generates code for wit Result types instead of exceptions | ||
| #[cfg_attr(feature = "clap", arg(long))] | ||
| pub with_wit_results: bool, |
Collaborator
Author
There was a problem hiding this comment.
open to name suggestions
dicej
approved these changes
Jan 8, 2025
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
LGTM; thanks! Just a few whitespace and grammar nits.
yowl
reviewed
Jan 8, 2025
yowl
reviewed
Jan 8, 2025
yowl
reviewed
Jan 8, 2025
yowl
reviewed
Jan 8, 2025
yowl
reviewed
Jan 8, 2025
Co-authored-by: yowl <scott.waye@hubse.com> Co-authored-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds option to generate Result types instead of handling Results via Exceptions: #1042