Remove support for usize and char8#197
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Apr 20, 2022
Merged
Conversation
peterhuene
approved these changes
Apr 19, 2022
sunfishcode
approved these changes
Apr 19, 2022
Member
sunfishcode
left a comment
There was a problem hiding this comment.
char8 was for UTF-8 code units; with interface types, users now use string instead.
usize was for lengths of buffers; with interface types, users now use list and streams instead.
Further iteration from bytecodealliance#195 and dropping more features that are only needed for `*.witx`, the `usize` and `char8` types were only added for backcompat with witx itself.
3cc3fe3 to
b3daad4
Compare
21 tasks
willemneal
pushed a commit
to theahaco/wit-bindgen
that referenced
this pull request
May 31, 2022
Further iteration from bytecodealliance#195 and dropping more features that are only needed for `*.witx`, the `usize` and `char8` types were only added for backcompat with witx itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further iteration from #195 and dropping more features that are only
needed for
*.witx, theusizeandchar8types were only added forbackcompat with witx itself.