Rename f32/f64 to float32/float64#198
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Apr 20, 2022
Merged
Conversation
This commit renames the previously-known `f32` and `f64` interface types to `float32` and `float64` to match the upstream specification.
sunfishcode
approved these changes
Apr 20, 2022
Member
sunfishcode
left a comment
sunfishcode
left a comment
There was a problem hiding this comment.
Looks good. The name change also signals the introduction of NaN canonicalization, but we can add that separately.
21 tasks
Member
Author
|
Good point! I'd actually forgotten that so I went ahead and made a checklist of known items at #201 -- let me know if I forgot something though |
Michael-F-Bryan
pushed a commit
to hotg-ai/wit-files
that referenced
this pull request
May 3, 2022
Michael-F-Bryan
pushed a commit
to hotg-ai/proc-blocks
that referenced
this pull request
May 3, 2022
Michael-F-Bryan
pushed a commit
to hotg-ai/wit-files
that referenced
this pull request
May 15, 2022
…pdate their fork This reverts commit 8518d3b.
willemneal
pushed a commit
to theahaco/wit-bindgen
that referenced
this pull request
May 31, 2022
* Rename f32/f64 to float32/float64 This commit renames the previously-known `f32` and `f64` interface types to `float32` and `float64` to match the upstream specification. * Fix a test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit renames the previously-known
f32andf64interface typesto
float32andfloat64to match the upstream specification.