Change the ABI for "join" on variants#199
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Apr 20, 2022
Merged
Conversation
This commit changes the ABI for variants such as `union { f32, f64 }`
which in the prior version of the canonical ABI would look like `i32
f64` but with the current canonical ABI draft it would instead look like
`i32 i64`. The previous `unify` function is updated to the new name used
in the canonical ABI explainer, `join`, the contents are modified, and
one form of bitcast was removed as a result.
Additionally I updated the bless'd output for `wasmlink` to ensure
everything has newlines at the end since I was getting some otherwise
odd changes locally. This is hopefully a one-time change for those
baselines.
21 tasks
peterhuene
approved these changes
Apr 20, 2022
willemneal
pushed a commit
to theahaco/wit-bindgen
that referenced
this pull request
May 31, 2022
This commit changes the ABI for variants such as `union { f32, f64 }`
which in the prior version of the canonical ABI would look like `i32
f64` but with the current canonical ABI draft it would instead look like
`i32 i64`. The previous `unify` function is updated to the new name used
in the canonical ABI explainer, `join`, the contents are modified, and
one form of bitcast was removed as a result.
Additionally I updated the bless'd output for `wasmlink` to ensure
everything has newlines at the end since I was getting some otherwise
odd changes locally. This is hopefully a one-time change for those
baselines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the ABI for variants such as
union { f32, f64 }which in the prior version of the canonical ABI would look like
i32 f64but with the current canonical ABI draft it would instead look likei32 i64. The previousunifyfunction is updated to the new name usedin the canonical ABI explainer,
join, the contents are modified, andone form of bitcast was removed as a result.
Additionally I updated the bless'd output for
wasmlinkto ensureeverything has newlines at the end since I was getting some otherwise
odd changes locally. This is hopefully a one-time change for those
baselines.