Add a Type::String variant#202
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Apr 21, 2022
Merged
Conversation
This removes the implicit interpretation that `list<char>` is equivalent to `string`, enabling `list<char>` to be equivalent to `&[char]` in Rust, for example. This commit is plumbed throughout all generators with new pseudo-instructions for lifting/lowering strings.
21 tasks
peterhuene
approved these changes
Apr 20, 2022
Member
peterhuene
left a comment
peterhuene
left a comment
There was a problem hiding this comment.
👍 Just some minor comment nits that can be ignored if you want.
Co-authored-by: Peter Huene <peter@huene.dev>
willemneal
pushed a commit
to theahaco/wit-bindgen
that referenced
this pull request
May 31, 2022
* Add a `Type::String` variant This removes the implicit interpretation that `list<char>` is equivalent to `string`, enabling `list<char>` to be equivalent to `&[char]` in Rust, for example. This commit is plumbed throughout all generators with new pseudo-instructions for lifting/lowering strings. * Apply suggestions from code review Co-authored-by: Peter Huene <peter@huene.dev> Co-authored-by: Peter Huene <peter@huene.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the implicit interpretation that
list<char>is equivalentto
string, enablinglist<char>to be equivalent to&[char]inRust, for example. This commit is plumbed throughout all generators with
new pseudo-instructions for lifting/lowering strings.