Skip to content

Remove async from features #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 1 commit into from
Oct 6, 2022
Merged

Remove async from features #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/gen-host-wasmtime-rust/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ anyhow = { workspace = true }
test-helpers = { path = '../test-helpers', features = ['host-wasmtime-rust'] }
wasmtime = { workspace = true }
wasmtime-wasi = { workspace = true }
wit-bindgen-host-wasmtime-rust = { workspace = true, features = ['tracing', 'async'] }
wit-bindgen-host-wasmtime-rust = { workspace = true, features = ['tracing'] }
1 change: 0 additions & 1 deletion crates/host-wasmtime-rust-macro/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ wit-bindgen-gen-host-wasmtime-rust = { workspace = true }

[features]
tracing = []
async = []
5 changes: 0 additions & 5 deletions crates/host-wasmtime-rust/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,9 @@ thiserror = "1.0"
wasmtime = { workspace = true }
wit-bindgen-host-wasmtime-rust-macro = { path = "../host-wasmtime-rust-macro", version = "0.2" }
tracing-lib = { version = "0.1.26", optional = true, package = 'tracing' }
async-trait = { version = "0.1.50", optional = true }

[features]
# Enables generated code to emit events via the `tracing` crate whenever wasm is
# entered and when native functions are called. Note that tracing is currently
# only done for imported functions.
tracing = ['tracing-lib', 'wit-bindgen-host-wasmtime-rust-macro/tracing']

# Enables async support for generated code, although when enabled this still
# needs to be configured through the macro invocation.
async = ['async-trait', 'wit-bindgen-host-wasmtime-rust-macro/async']
2 changes: 0 additions & 2 deletions crates/host-wasmtime-rust/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
pub use wit_bindgen_host_wasmtime_rust_macro::{export, import};

#[cfg(feature = "async")]
pub use async_trait::async_trait;
#[cfg(feature = "tracing-lib")]
pub use tracing_lib as tracing;
#[doc(hidden)]
Expand Down