fix(go): enable all the codegen tests for go generator#588
Merged
alexcrichton merged 5 commits intobytecodealliance:mainfrom May 31, 2023
Merged
fix(go): enable all the codegen tests for go generator#588alexcrichton merged 5 commits intobytecodealliance:mainfrom
alexcrichton merged 5 commits intobytecodealliance:mainfrom
Conversation
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
Mossaka
changed the title
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
alexcrichton
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes all the breaking codegen tests in the go generator, closes #589 . In addition, this PR also adds variants tests which can close #528 and PR #527 . It builds on top of #587