Remove requirement that the module to link exports _start.#60
Merged
peterhuene merged 2 commits intobytecodealliance:mainfrom Aug 9, 2021
Merged
Remove requirement that the module to link exports _start.#60peterhuene merged 2 commits intobytecodealliance:mainfrom
_start.#60peterhuene merged 2 commits intobytecodealliance:mainfrom
Conversation
This commit removes the requirement that the root module being linked exports a `_start` function. Instead, it now simply reexports all exported functions. This will enable use of the linked modules from profiles where a start function isn't necessary (i.e. the host will call some other function). Updated the CLI to remove references to a "main" module. Fixes bytecodealliance#59.
Member
Author
|
cc @radu-matei |
alexcrichton
approved these changes
Aug 9, 2021
This commit also adds exporting any exported memories from the root module after linking.
radu-matei
approved these changes
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the requirement that the root module being linked
exports a
_startfunction.Instead, it now simply reexports all exported functions. This will
enable use of the linked modules from profiles where a start function
isn't necessary (i.e. the host will call some other function).
Updated the CLI to remove references to a "main" module.
Fixes #59.