c#: Update to use latest packages incorporating WasmImportLinkage #791
Conversation
Remove WasmImport from csproj Move cabi-realloc to c
redo import name
crates/csharp/src/lib.rs
Outdated
| namespace {namespace}.{name}; | ||
| // temporarily add this attribute until it is available in dotnet 9 | ||
| namespace System.Runtime.InteropServices |
There was a problem hiding this comment.
This is in a for loop so gets printed twice in some cases (which is why CI is failing)
I think we could move put this where internal static class Intrinsics was so it only gets printed once
There was a problem hiding this comment.
Thanks, Yes I have some more changes pending, but until the packages are published dotnet/runtimelab#2462, then I've left this as draft
tests/runtime/main.rs
Outdated
| csproj.generate()?; | ||
|
|
||
| // generate the cabi_realloc (and TODO: release) | ||
| let mut cmd_emcc = Command::new("emcc.bat"); |
There was a problem hiding this comment.
maybe this can be a task in the csproj.cs that builds if that c file is present?
There was a problem hiding this comment.
So that it builds as part of the user dotnet publish ?
There was a problem hiding this comment.
that's what I was thinking, since its a file we generate and it needs to be compiled to be usable component
There was a problem hiding this comment.
Thanks, added to the csproj.
|
do we need bump the dotnet AOT compiler version anywhere? |
Yes we do. Incoming, when the packages publish. |
3 participants
This PR removes the
WasmImporttag from the project file now that theWasmImportLinkageAttributehas been accepted upstream and merged into Ilc. Note that it is not in the published dotnet SDK yet so we need to add the attribute to the generated code until we update to dotnet 9 SDK (and tooling which supports it).Also moves
cabi_reallocto c code, fixing #777 . I did try a few things to avoid adding C code and invoking emcc to compile that code to a wasm object file.cc @jsturtevant @silesmo