Reactor::wait_for takes &Pollable instead of Pollable#28
Closed
Reactor::wait_for takes &Pollable instead of Pollable#28
&Pollable instead of Pollable#28Conversation
We want to be able to reuse a pollable on many uses in the reactor. The fundamental underlying operation `wasi:io/poll.poll` takes a `list<borrow<pollable>>`, or `&[&Pollable]` in Rust. The `Poller` structure needs to be changed to unsafe transmute the `&Pollable` to a common lifetime for passing to `poll`. This remains safe as long as each caller that inserts a `&Pollable` unconditionally removes it.
pchickey
force-pushed
the
pch/wait_for_ref_pollable
branch
from
6f78a41 to
c740f1b
Compare
Contributor
Author
|
This was not the way to go, I figured it out in #35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to be able to reuse a pollable on many uses in the reactor.
The fundamental underlying operation
wasi:io/poll.polltakes alist<borrow<pollable>>, or&[&Pollable]in Rust.The
Pollerstructure needs to be changed to unsafe transmute the&Pollableto a common lifetime for passing topoll. This remains safe as long as each caller that inserts a&Pollableunconditionally removes it.