Introduce AsyncInputStream, AsyncOutputStream, and stdio#37
Merged
Conversation
* eliminate its internal OutputStream wrapper. * fix io::copy to bubble up body copy error rather than panic. * add http error variant for io errors on body.
this eliminates the buffering behavior that IncomingBody previously had. Will have to define a BufReader for AsyncRead at some point so users can opt back into that if they want it.
This was referenced Dec 28, 2024
This was referenced Dec 28, 2024
pchickey
added a commit
that referenced
this pull request
Dec 28, 2024
This was referenced Dec 28, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and convert all of the crate's uses of InputStream/OutputStream/Pollable to use their Async wrappers.
--nocapturefor each of stdout and stderr, but no test for stdin yet. That will have to be written in the style of the tcp echo server test, in a future PR.Closes #23