Allow non-pollable woken futures to make progress#71
Merged
Conversation
This test demonstrates behavior for a future which does not pend on a pollable, but does wake the root task when pending. As long as the root task has had wake() called, the runtime should keep polling it. This bug was reported in #69 and this test was derived from one written by @SilverMira in https://github.com/SilverMira/wstd/tree/allow_independent_futures Co-Authored-By: SilverMira <66930495+SilverMira@users.noreply.github.com>
yoshuawuyts
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69
Alternative to #70 that tracks the state of the root task's waker, and keeps polling if that waker is awake.