Clean up arithmetic dimensionality#11
Closed
HadrienG2 wants to merge 1 commit intobytesize-rs:masterfrom
HadrienG2:dimensionality
Closed
Clean up arithmetic dimensionality#11HadrienG2 wants to merge 1 commit intobytesize-rs:masterfrom HadrienG2:dimensionality
HadrienG2 wants to merge 1 commit intobytesize-rs:masterfrom
HadrienG2:dimensionality
Conversation
Member
|
I'm sorry for a late response. As you suggested, I also cleaned up the arithmetic operators. You can see the improvement at https://github.com/hyunsik/bytesize/releases/tag/release-0.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing arithmetic between ByteSizes and raw integers requires a little bit of care
This was discussed in issue #2, and this MR implements the proposed set of arithmetic operators.