Added a more intuitive helper struct when printing ByteSize#32
Closed
ChanTsune wants to merge 2 commits intobytesize-rs:masterfrom
Closed
Added a more intuitive helper struct when printing ByteSize#32ChanTsune wants to merge 2 commits intobytesize-rs:masterfrom
ChanTsune wants to merge 2 commits intobytesize-rs:masterfrom
Conversation
dbcb3ad to
9530285
Compare
9530285 to
e2c7442
Compare
e2c7442 to
0d9d9c4
Compare
Contributor
Author
|
@robjtede I resolved conflict! |
wookietreiber
approved these changes
Feb 11, 2025
Member
|
We'll chat about this approach once #69 is merged |
This was referenced Feb 12, 2025
Merged
Member
|
I took inspiration from this and the Thank you for your contibution to the project 🎉 this has been a much needed feature request imo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Displaytrait currently implemented inByteSizeonly supports decimal prefixes.If we want to use a binary prefix, we need to use
ByteSize::to_string_as.I have added helper some struct and methods to use them to
ByteSizeto make these more intuitive with refer tostd::path::Path.If you like this PR, it would be my pleasure if you merge it!