Skip to content

Comments

feat: impl Sub and SubAssign for bytesize#56

Merged
robjtede merged 2 commits intomasterfrom
xx/sub
Nov 18, 2024
Merged

feat: impl Sub and SubAssign for bytesize#56
robjtede merged 2 commits intomasterfrom
xx/sub

Conversation

@MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Nov 18, 2024

close #39

@MrCroxx
feat: impl Sub and SubAssign for bytesize
4e95b48 
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx self-assigned this Nov 18, 2024
@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Nov 18, 2024

@robjtede PTAL 🥰

@robjtede
Copy link
Member

robjtede commented Nov 18, 2024

LGTM but since we're keeping a changelog now lets add these:

- Implement `Sub<ByteSize>` for `ByteSize`.
- Implement `Sub<impl Into<u64>>` for `ByteSize`.
- Implement `SubAssign<ByteSize>` for `ByteSize`.
- Implement `SubAssign<impl Into<u64>>` for `ByteSize`.

@MrCroxx
docs: record updates in the changelog
da9d345 
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@robjtede robjtede merged commit 9eefdcd into master Nov 18, 2024
robjtede pushed a commit to Andrew15-5/bytesize that referenced this pull request Feb 10, 2025
@MrCroxx @robjtede
feat: impl Sub and SubAssign for bytesize (bytesize-rs#56)
b9728ce
@robjtede robjtede deleted the xx/sub branch March 31, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robjtede robjtede robjtede approved these changes

Assignees

@MrCroxx MrCroxx

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Sub trait

2 participants

@MrCroxx @robjtede