Conversation
robjtede
force-pushed
the
nostd
branch
3 times, most recently
from
9ec33a4 to
0b5d638
Compare
Closed
MrCroxx
approved these changes
Feb 21, 2025
Comment on lines
+125
to
126
| #[allow(unused_variables)] // used in std contexts | ||
| let unit_base = self.format.unit_base(); |
Collaborator
There was a problem hiding this comment.
Could we also use conditional compiling like #[cfg(feature = 'std')] here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very do-able within this crate. The biggest obstacle isn't even string or allocations, it's the lack of
f64::ln()in no-std contexts.We can calculate the ideal unit prefix with a simple loop though. I added property tests to prove that it has the same results as the ln method.
closes #3