Skip to content

Modules#9

Draft
mlanci wants to merge 3 commits intomainfrom
modules
Draft

Modules#9
mlanci wants to merge 3 commits intomainfrom
modules

Conversation

@mlanci
Copy link
Collaborator

@mlanci mlanci commented Mar 27, 2024

I've got the http://localhost:3000/game/33ea1dc1-74c5-431e-a314-683198a88d83 loading a module from the database.

On a new game create - we are not writing in a proper format to the database (match all json body structure to the "GAME" item with sk = 33ea1dc1-74c5-431e-a314-683198a88d83). Also the list of games that the user has joined is broken at this point

@mlanci mlanci requested a review from c-stone March 27, 2024 14:03
@vercel
Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stat-it ❌ Failed (Inspect) Mar 30, 2024 8:43pm

@mlanci mlanci marked this pull request as draft March 27, 2024 14:03
@c-stone
Copy link
Owner

c-stone commented Mar 27, 2024

Type error: Type 'number | undefined' is not assignable to type 'number'.
  Type 'undefined' is not assignable to type 'number'.
  30 |                 <Counter
  31 |                   key={index}
> 32 |                   value={component.value}
     |                   ^
  33 |                   name={component.name || ""}
  34 |                   onRemove={() => {}}
  35 |                 />
 ELIFECYCLE  Command failed with exit code 1.
Error: Command "pnpm run build" exited with 1

Looks like value requires a default value, something like:

<Counter
  key={index}
  value={component.value || 0} // Provide 0 (or another default number) if component.value is undefined
  name={component.name || ""}
  onRemove={() => {}}
/>

@mlanci
Copy link
Collaborator Author

mlanci commented Mar 27, 2024

Yeah I set this one to draft because I knew it wouldn't pass a build yet - work in progress!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants