Identity matches from run processing report #1086
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to adapt to viewport.
…for warnings. Removed some testing values. Tweaked display some.
…ngs (removed the mirroring of the matches when a readset is present).
UlysseFG
force-pushed
the
identity-matches-for-experiments
branch
from
6cfc67c to
f032d75
Compare
nafiz1001
reviewed
Jan 7, 2026
Collaborator
Author
There was a problem hiding this comment.
Yeah this is a temporary migration i left there until we are done to have some identity and identity_matches to test with ...
nafiz1001
reviewed
Jan 7, 2026
| return sample_identity, kept_existing_identity, errors, warnings | ||
|
|
||
| def create_sample_identity_matches(tested_identity: SampleIdentity, matches_by_biosample_id: dict[int, Identity_match_info]): | ||
| def create_sample_identity_matches(tested_identity: SampleIdentity, matches_by_biosample_id: dict[int, Identity_match_info], readset_obj: Readset = None): |
nafiz1001
reviewed
Jan 7, 2026
Comment on lines
+227
to
+229
| runTypes: { | ||
| list: () => get("/run-types/"), | ||
| }, |
Collaborator
There was a problem hiding this comment.
Oh there already was no type. Fair enough.
nafiz1001
reviewed
Jan 7, 2026
Collaborator
There was a problem hiding this comment.
You should use redux toolkit for Redux action-reducers ;)
nafiz1001
reviewed
Jan 7, 2026
Collaborator
There was a problem hiding this comment.
You should use redux toolkit for Redux action-reducers ;)
Collaborator
Author
There was a problem hiding this comment.
Not sure i want ... Looks like another layer to the ever expanding onion ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.