Skip to content

Conversation

@nafiz1001
Copy link
Collaborator

No description provided.

@nafiz1001 nafiz1001 requested a review from UlysseFG December 9, 2025 17:55
@nafiz1001 nafiz1001 marked this pull request as draft December 9, 2025 19:20
@nafiz1001 nafiz1001 marked this pull request as ready for review December 10, 2025 20:33
* @type {NonNullable<import("antd").StepsProps['items']>}
*/
const steps = STEPS.map((s) => ({
title: s.title,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Item no longer need key ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lack of warning tells me it's no longer needed.

*/
const steps = STEPS.map((s) => ({
title: s.title,
description: s.description(action.description),
Copy link
Collaborator

@UlysseFG UlysseFG Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format of the description in the new component is too flat. it looked better before when it wrapped more compactly. Not sure it's possible to get that result anymore without much thinkering.<nitpick>

@UlysseFG
Copy link
Collaborator

DropdownListItems.js seem to be exploding for multiple items in the list.

Uncaught Error: React.Children.only expected to receive a single React element child.

I got that when queuing sample to multiple steps in the Assign Workflow section. I also get that from indices with multiple sequences (ie index 9569).

@nafiz1001 nafiz1001 requested a review from UlysseFG December 24, 2025 14:02
@nafiz1001 nafiz1001 merged commit 61c7edc into master Jan 6, 2026
@nafiz1001 nafiz1001 deleted the prepare-for-antd-6 branch January 6, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants