Add option to sign tags.#6
Conversation
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I recently realized that this is needed and there's no git config setting to always sign commits so 👍 for adding this.
|
|
||
| @classmethod | ||
| def tag(cls, name, message): | ||
| def tag(cls, sign, name, message): |
There was a problem hiding this comment.
I think this should raise an error when sign is true that it's not supported.
|
Bumping in case it got lost in your inbox @c4urself. Thanks! |
|
Thanks @Californian! @c4urself do you want to do a release? I'm not sure I have permissions to do so. |
|
yep -- will try to get a release out this week. it would be nice if you also get the permissions, not sure what you need for that? |
|
My username on pypi is the same as my github. You should be able to log in on pypi, go to the bump2version package and select the roles tab. There you can add me as an owner or maintainer. https://pypi.python.org/pypi?:action=role_form&package_name=bump2version should be the direct URL. |
|
Done. |
4 participants
Also added standard
.gitignorefiles for Python and vim.The test for Python 3.3 does not pass, but that appears to be because of an upstream issue checking out a required package.
A test to check that signatures are actually made has not been written, but it has been verified manually. I can add a test later, but it is a bit involved (it would require adding
gpgto theDockerfileand generating a signature in the test setup) and I do not currently have time for that.Closes GH-5