Skip to content

No rewrite config file when bumping #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albireox wants to merge 2 commits into from
Closed

No rewrite config file when bumping #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b30894
Add config file to list of files to bump
albireox Oct 5, 2019
9424485
Call _update_config_file but only write if file does not exist
albireox Oct 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bumpversion/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ def main(original_args=None):
for file_name
in (file_names or positionals[1:])
)

if config_file_exists and config_file not in files:
files.extend([ConfiguredFile(config_file, version_config)])

_check_files_contain_version(files, current_version, context)
_replace_version_in_files(files, current_version, new_version, args.dry_run, context)
_log_list(config, args.new_version)
Expand Down Expand Up @@ -606,7 +610,7 @@ def _update_config_file(
config.set("bumpversion", "current_version", new_version)
new_config = StringIO()
try:
write_to_config_file = (not dry_run) and config_file_exists
write_to_config_file = (not dry_run) and not config_file_exists

logger.info(
"%s to config file %s:",
Expand Down